[webkit-reviews] review denied: [Bug 21445] on windows, we try to remove m_smallCapsFontData from the font cache, but we never added it there : [Attachment 24161] [1/1] Fix a bug where we try to release font data from the font cache when it

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 7 14:30:54 PDT 2008


Dave Hyatt <hyatt at apple.com> has denied Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 21445: on windows, we try to remove m_smallCapsFontData from the font
cache, but we never added it there
https://bugs.webkit.org/show_bug.cgi?id=21445

Attachment 24161: [1/1] Fix a bug where we try to release font data from the
font cache when it
https://bugs.webkit.org/attachment.cgi?id=24161&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
You don't want to cache a custom font.	You only want to patch the
non-custom-font  code path.  Technically on Windows the small caps font won't
ever be shared, but for cross-platform consistency it's better to have that in
the cache even if it's pointless. :)

However I see an additional bug, namely that small caps font data in the custom
font path is leaking.  The SimpleFontData destructor is not deleting
m_smallCapsFontData in the custom font case.


More information about the webkit-reviews mailing list