[webkit-reviews] review denied: [Bug 20760] Implement support for x86 Linux in CTI : [Attachment 24112] Enable SFX on Linux/GTK
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 7 11:14:59 PDT 2008
Mark Rowe (bdash) <mrowe at apple.com> has denied Alp Toker <alp at nuanti.com>'s
request for review:
Bug 20760: Implement support for x86 Linux in CTI
https://bugs.webkit.org/show_bug.cgi?id=20760
Attachment 24112: Enable SFX on Linux/GTK
https://bugs.webkit.org/attachment.cgi?id=24112&action=edit
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
This generally looks good, but I'm going to mark it as r- due to the
duplication of the definitions for CTI_ARGS. Changing m_wrecFunction to a
void* doesn't seem great either.
More information about the webkit-reviews
mailing list