[webkit-reviews] review granted: [Bug 20651] svgElement.className.baseValue does not work : [Attachment 24124] Potential fix for element.className.baseValue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 7 09:40:49 PDT 2008

Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 20651: svgElement.className.baseValue does not work

Attachment 24124: Potential fix for element.className.baseValue

------- Additional Comments from Darin Adler <darin at apple.com>
Can the test be changed into a dumpAsText test? I was able to do a number of
SVG tests that were portable that way.

+ if (attrName == HTMLNames::classAttr)

I'm surprised you chose to explicitly qualify here rather than doing using
namespace HTMLNames.

StyledElement::classAttributeChanged would be better if it only called
setChanged when there was an actual change. But that's not part of this fix, I


More information about the webkit-reviews mailing list