[webkit-reviews] review denied: [Bug 20932] Notable leaks in QtWebkit - from Qt library : [Attachment 24053] Patch for robotized work of QtLauncher

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 7 01:51:30 PDT 2008

Simon Hausmann <hausmann at webkit.org> has denied Kelemen Balázs
<Kelemen.Balazs.3 at stud.u-szeged.hu>'s request for review:
Bug 20932: Notable leaks in QtWebkit - from Qt library

Attachment 24053: Patch for robotized work of QtLauncher

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
97     QWebView *webView() const {

Small coding style nitpick: Please use QWebView* webView()

389	WTF::Vector<QString*> m_urls;

QString is a value based class, you can simplify your code a lot and free it
from leaks by using WTF::Vector<QString> instead. Right now the QStrings
allocated in it are never freed.

In fact for the init() function I suggest the use of QString for the inputFile
argument and I also suggest the use of QFile and QTextStream instead of the C
file API. It will make your code simplier and more portable :)

r- for now, but in principle I agree with your patch and idea and I'd love to
see the patch go in :)

More information about the webkit-reviews mailing list