[webkit-reviews] review requested: [Bug 20760] Implement support for x86 Linux in CTI : [Attachment 24112] Enable SFX on Linux/GTK

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 6 02:05:46 PDT 2008


Alp Toker <alp at nuanti.com> has asked  for review:
Bug 20760: Implement support for x86 Linux in CTI
https://bugs.webkit.org/show_bug.cgi?id=20760

Attachment 24112: Enable SFX on Linux/GTK
https://bugs.webkit.org/attachment.cgi?id=24112&action=edit

------- Additional Comments from Alp Toker <alp at nuanti.com>
 ChangeLog			    |	11 ++++++++++
 JavaScriptCore/ChangeLog	    |	39
+++++++++++++++++++++++++++++++++++++
 JavaScriptCore/GNUmakefile.am	    |	 8 +++++++
 JavaScriptCore/VM/CTI.cpp	    |	22 +++++++++++++++-----
 JavaScriptCore/VM/CTI.h	    |	 2 -
 JavaScriptCore/VM/Machine.cpp	    |	 3 ++
 JavaScriptCore/VM/Machine.h	    |	13 ++++++++----
 JavaScriptCore/kjs/regexp.cpp	    |	 9 ++++----
 JavaScriptCore/kjs/regexp.h	    |	 3 --
 JavaScriptCore/masm/X86Assembler.h |	 9 +++++---
 configure.ac			    |	22 ++++++++++++++++++--
 11 files changed, 119 insertions(+), 22 deletions(-)

Enables CTI/WREC in the GTK+ port and avoids some over-inclusion of headers
(bug #3761).

The CTI_ARGUMENT preprocessor checks have been made consistent so the
workaround can be enabled/disabled on both GCC and MSVC, though it seems to
work fine now without this.

I think we're ready to enable CTI/WREC for GTK and see if anyone complains.
QT/WX can trivially enable it in their build systems too after this lands.

Thanks to Mark and Gavin for inspiration.


More information about the webkit-reviews mailing list