[webkit-reviews] review granted: [Bug 21364] Remove the branch in op_ret for OptionalCalleeActivation and OptionalCalleeArguments : [Attachment 24104] Proposed patch to refactor some code in preparation for the speedup

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has granted Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 21364: Remove the branch in op_ret for OptionalCalleeActivation and
OptionalCalleeArguments
https://bugs.webkit.org/show_bug.cgi?id=21364

Attachment 24104: Proposed patch to refactor some code in preparation for the
speedup
https://bugs.webkit.org/attachment.cgi?id=24104&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

You may want to consider giving scopeChain a needsActivation method which
checks for any of the needed conditions rather than having such a complex field
initializer.