[webkit-reviews] review granted: [Bug 21365] WebKit supports <font descent= but should support <font-face descent=! : [Attachment 24087] WebCore changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 4 08:22:05 PDT 2008


Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 21365: WebKit supports <font descent= but should support <font-face
descent=!
https://bugs.webkit.org/show_bug.cgi?id=21365

Attachment 24087: WebCore changes
https://bugs.webkit.org/attachment.cgi?id=24087&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks fine, but I would have put this and the test changes into a single patch.


+    AtomicString value = getAttribute(ascentAttr);

To avoid a little reference count churn, this really should be const
AtomicString& value.

r=me


More information about the webkit-reviews mailing list