[webkit-reviews] review denied: [Bug 21338] IDL files use #if defined(ENABLE_whatever) instead of #if ENABLE_whatever : [Attachment 24064] grep -r ^#if.\*ENABLE_ .

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 3 19:13:03 PDT 2008


Timothy Hatcher <timothy at hatcher.name> has denied Mark Mentovai
<mark at moxienet.com>'s request for review:
Bug 21338: IDL files use #if defined(ENABLE_whatever) instead of #if
ENABLE_whatever
https://bugs.webkit.org/show_bug.cgi?id=21338

Attachment 24064: grep	-r ^#if.\*ENABLE_ .
https://bugs.webkit.org/attachment.cgi?id=24064&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Change is fine but please add a description and bug url to the changelog.


More information about the webkit-reviews mailing list