[webkit-reviews] review granted: [Bug 21352] Clean up how tracking of code features is done in the parser a bit : [Attachment 24074] cleanup patch

[bugzilla-daemon at webkit.org]

Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 21352: Clean up how tracking of code features is done in the parser a bit
https://bugs.webkit.org/show_bug.cgi?id=21352

Attachment 24074: cleanup patch
https://bugs.webkit.org/attachment.cgi?id=24074&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
> static ProgramNode* create(JSGlobalData*, SourceElements*, VarStack*,
FunctionStack*, const SourceCode&, CodeFeatures featureso, int numConstants)
JSC_FAST_CALL;

You should change 'featureso' to 'features', or better yet, remove the name of
the CodeFeatures parameter in prototypes. Other than that, r=me assuming it
passes tests.