[webkit-reviews] review requested: [Bug 21303] Auto scroll does not work for Gtk - again : [Attachment 24049] Kill off more of ScrollViewGtk, fix GTK+ rendering issues

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 3 05:24:06 PDT 2008


Alp Toker <alp at nuanti.com> has asked  for review:
Bug 21303: Auto scroll does not work for Gtk - again
https://bugs.webkit.org/show_bug.cgi?id=21303

Attachment 24049: Kill off more of ScrollViewGtk, fix GTK+ rendering issues
https://bugs.webkit.org/attachment.cgi?id=24049&action=edit

------- Additional Comments from Alp Toker <alp at nuanti.com>
 WebCore/ChangeLog			       |   42 ++++++
 WebCore/platform/ScrollView.cpp	       |   18 --
 WebCore/platform/ScrollView.h		       |    2 
 WebCore/platform/gtk/ScrollViewGtk.cpp        |  180
+++++++-------------------
 WebCore/platform/gtk/ScrollbarGtk.cpp	       |  110 ++++++++++-----
 WebCore/platform/gtk/ScrollbarGtk.h	       |    5 
 WebKit/gtk/ChangeLog			       |   28 ++++
 WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp |   50 ++++++-
 WebKit/gtk/webkit/webkitwebview.cpp	       |   24 +++
 9 files changed, 263 insertions(+), 196 deletions(-)

So, I took the recent breakage as an opportunity to fix invalidation/repaint
issues we've had in the GTK+ port since the early days and kill off the cruft
in ScrollViewGtk/ScrollViewPrivate (which are almost dead now).


More information about the webkit-reviews mailing list