[webkit-reviews] review granted: [Bug 21328] Make invalidation of widgets more cross-platform : [Attachment 24041] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 3 00:00:55 PDT 2008

Sam Weinig <sam at webkit.org> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 21328: Make invalidation of widgets more cross-platform

Attachment 24041: Patch

------- Additional Comments from Sam Weinig <sam at webkit.org>
Couple of nits.

+    ::InvalidateRect(m_popup, &r,false);
Missing space.

 void Widget::invalidateRect(const IntRect& r)
Please remove this commented out code.

+    // Do windowless plugin invalidation.
+    invalidateWindowlessPluginRect(rect);
The comment doesn't really add anything here.

+    PluginWidget(NSView *view = 0)
+    : Widget(view)
The initializer list should be indented more.

+	 [platformWidget() setNeedsDisplayInRect: rect];
Extra space.

-    : Widget(view)
+    : PluginWidget(view)
Initialize list issue again.


More information about the webkit-reviews mailing list