[webkit-reviews] review granted: [Bug 21328] Make invalidation of widgets more cross-platform : [Attachment 24041] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 3 00:00:55 PDT 2008
Sam Weinig <sam at webkit.org> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 21328: Make invalidation of widgets more cross-platform
https://bugs.webkit.org/show_bug.cgi?id=21328
Attachment 24041: Patch
https://bugs.webkit.org/attachment.cgi?id=24041&action=edit
------- Additional Comments from Sam Weinig <sam at webkit.org>
Couple of nits.
+ ::InvalidateRect(m_popup, &r,false);
Missing space.
+/*
void Widget::invalidateRect(const IntRect& r)
Please remove this commented out code.
+ // Do windowless plugin invalidation.
+ invalidateWindowlessPluginRect(rect);
The comment doesn't really add anything here.
+ PluginWidget(NSView *view = 0)
+ : Widget(view)
The initializer list should be indented more.
+ [platformWidget() setNeedsDisplayInRect: rect];
Extra space.
- : Widget(view)
+ : PluginWidget(view)
Initialize list issue again.
r=me!
More information about the webkit-reviews
mailing list