[webkit-reviews] review granted: [Bug 21314] Make scrollBackingStore cross-platform. : [Attachment 24028] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 2 13:10:30 PDT 2008
Sam Weinig <sam at webkit.org> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 21314: Make scrollBackingStore cross-platform.
https://bugs.webkit.org/show_bug.cgi?id=21314
Attachment 24028: Patch
https://bugs.webkit.org/attachment.cgi?id=24028&action=edit
------- Additional Comments from Sam Weinig <sam at webkit.org>
+ virtual void scroll(const IntSize& scrollDelta, const IntRect&
rectToScroll, const IntRect& clipRect) { }
There should not be the "= false"
+ if (canBlitOnScroll()) // The main frame can just blit the WebView window
+ // FIXME: Find a way to blit subframes without blitting overlapping
content
+ hostWindow()->scroll(-scrollDelta, scrollViewRect, clipRect);
+ else
+ // We need to go ahead and repaint the entire backing store. Do it now
before moving the
+ // plugins.
+ hostWindow()->repaint(updateRect, true, false, true); // Invalidate the
backing store and repaint it synchronously
This if-else needs braces as the statements + comments are more than 1 line.
r=me
More information about the webkit-reviews
mailing list