[webkit-reviews] review denied: [Bug 20625] ConsoleMessage should have a "type" attribute : [Attachment 23938] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 2 12:17:38 PDT 2008

Timothy Hatcher <timothy at hatcher.name> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 20625: ConsoleMessage should have a "type" attribute

Attachment 23938: patch

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
This needs some updates to work with TOT.

	     // This _format call passes in true for the plainText argument.
The result's textContent is
	     // used for inline message bubbles in SourceFrames, or other
plain-text representations.
-	     this.message = this._format(Array.prototype.slice.call(arguments,
6), true).textContent;
+	     this.message = this._format(Array.prototype.slice.call(arguments,
7), true).textContent;
	     // The formatedMessage property is used for the rich and
interactive console.
-	     this.formattedMessage =
this._format(Array.prototype.slice.call(arguments, 6));
+	     this.formattedMessage =
this._format(Array.prototype.slice.call(arguments, 7));

We no longer call _format twice.

Otherwise looks good! But r- until it can apply to TOT,

More information about the webkit-reviews mailing list