[webkit-reviews] review requested: [Bug 21292] enclosingIntRect doesn't handle negative offsets : [Attachment 24024] New patch with rebaselined layout tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 2 11:36:47 PDT 2008


Brett Wilson (Google) <brettw at chromium.org> has asked  for review:
Bug 21292: enclosingIntRect doesn't handle negative offsets
https://bugs.webkit.org/show_bug.cgi?id=21292

Attachment 24024: New patch with rebaselined layout tests
https://bugs.webkit.org/attachment.cgi?id=24024&action=edit

------- Additional Comments from Brett Wilson (Google) <brettw at chromium.org>
This ended up changing a bunch of layout test results. I checked a bunch of the
pages and there was no visible difference.

In most cases, the change is obvious looking at the text dump. Most of the
problems are when negative coordinates are involved, and the rectangles can get
either bigger or smaller depending on the input.


More information about the webkit-reviews mailing list