[webkit-reviews] review requested: [Bug 20664] [GTK] File names are not always encodable in UTF-8 : [Attachment 24021] Add filenameToString, filenameFromString and filenameForDisplay to FileSystemGtk.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 2 09:46:32 PDT 2008


Marco Barisione <marco.barisione at collabora.co.uk> has asked  for review:
Bug 20664: [GTK] File names are not always encodable in UTF-8
https://bugs.webkit.org/show_bug.cgi?id=20664

Attachment 24021: Add filenameToString, filenameFromString and
filenameForDisplay to FileSystemGtk.cpp
https://bugs.webkit.org/attachment.cgi?id=24021&action=edit

------- Additional Comments from Marco Barisione
<marco.barisione at collabora.co.uk>
(In reply to comment #10)
> (From update of attachment 23441 [edit])
>  87	      gchar* systemFilename =
> filenameFromString(m_filename.utf8().data());
> 
> That can just be:
>  87	      gchar* systemFilename = filenameFromString(m_filename);
> or?

Yeah, I didn't see that. Fixed.

> I think all the imported code from GLIB should live in a separate header/.cpp

> pair, that way it can have its own special indentation for that file. 
Although
> I'm not sure that's really enough code (at least for is_valid) to really
> justify needing to be copy/pasted from glib.

Done. is_valid is there only because it's used by another function copied from
glib, I don't use it directly.

> such things? Besides that question it seems to be done. If we manage to land
> bug #18987 first you might need to upload a new diff though.

Updated. For this chance I also added filenameForDisplay that converts an
encoded string to a UTF-8 string for display, useful for error messages for
instance.


More information about the webkit-reviews mailing list