[webkit-reviews] review granted: [Bug 21292] enclosingIntRect doesn't handle negative offsets : [Attachment 24020] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 2 08:44:52 PDT 2008


Sam Weinig <sam at webkit.org> has granted Brett Wilson (Google)
<brettw at chromium.org>'s request for review:
Bug 21292: enclosingIntRect doesn't handle negative offsets
https://bugs.webkit.org/show_bug.cgi?id=21292

Attachment 24020: Patch
https://bugs.webkit.org/attachment.cgi?id=24020&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
Looks good.  I am curious why it was removed in the first place though. 
Perhaps hyatt will share.

+	 incorrect. I am not having problems building it on Windows, which was
+	 the reason for that change. 
There is no reason to include this personal detail.

r=me


More information about the webkit-reviews mailing list