[webkit-reviews] review granted: [Bug 21298] Make updateScrollbars cross-platform : [Attachment 24009] Patch #3

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 21298: Make updateScrollbars cross-platform
https://bugs.webkit.org/show_bug.cgi?id=21298

Attachment 24009: Patch #3
https://bugs.webkit.org/attachment.cgi?id=24009&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
+	 The ScrollView now implement ScrollbarClient, which means that there
was a clash of windowClipRect methods from the
s/implement/implements/

+	     }
+	 }
+	 else {
+	     scrollsHorizontally = (hScroll == ScrollbarAuto) ?
hasHorizontalScrollbar : (hScroll == ScrollbarAlwaysOn);

The else should be on the same line as the }.

+	 if (pageStep < 0) pageStep = clientWidth;
This should be on two lines.

+	 if (pageStep < 0) pageStep = clientHeight;
As should this

-// FIXME: ScrollViewPrivate will eventually be completely gone.  It's already
gone on Mac.
-#if !PLATFORM(MAC)
+// FIXME: ScrollViewPrivate will eventually be completely gone.
I think this #if was incorrectly removed.

Otherwise, looks nice.	r=me.