[webkit-reviews] review granted: [Bug 21281] Some parser cleanup : [Attachment 24003] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 1 22:28:08 PDT 2008

Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has granted 's request for
Bug 21281: Some parser cleanup

Attachment 24003: patch

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
In the ChangeLog, you say wtf:: instead of WTF::.

You use both sourceID and sourceId in your patch. I know the latter is because
the original code had it, but you should probably pick one and stick with it.
Since sourceID is our coding style, that seems like a good choice.

I will say r=me, but due to Darin's earlier review, I would like to see this
looked over by him after it lands.

More information about the webkit-reviews mailing list