[webkit-reviews] review granted: [Bug 21214] speed up function calls by eliminating the need for a new ExecState each time : [Attachment 23994] patch to remove some uses of dynamicGlobalObject

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 1 15:12:39 PDT 2008


Eric Seidel <eric at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 21214: speed up function calls by eliminating the need for a new ExecState
each time
https://bugs.webkit.org/show_bug.cgi?id=21214

Attachment 23994: patch to remove some uses of dynamicGlobalObject
https://bugs.webkit.org/attachment.cgi?id=23994&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
None of these dynamic -> lexical change behavior?  It's not possible to
override the object prototype I assume? (thus it's functionally equivalent to
ask on either global object?)  The shell ones I would believe, since no one
really cares about the shell, the Object.prototype I have less context for to
make an informed decision.

Otherwise looks fine.


More information about the webkit-reviews mailing list