[webkit-reviews] review granted: [Bug 21282] Make contentsToScreen and screenToContents cross-platform : [Attachment 23988] Patch #2

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 21282: Make contentsToScreen and screenToContents cross-platform
https://bugs.webkit.org/show_bug.cgi?id=21282

Attachment 23988: Patch #2
https://bugs.webkit.org/attachment.cgi?id=23988&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
+++ WebKit/gtk/WebCoreSupport/ChromeClientGtk.h (working copy)
@@ -88,6 +88,8 @@ namespace WebKit {
	 virtual void updateBackingStore();
 
	 virtual void repaint(const WebCore::IntRect&, bool contentChanged,
bool immediate = false);
+	 virtual IntPoint screenToWindow(const IntPoint& p) const;
+	 virtual IntRect windowToScreen(const IntRect& r) const;

Looks like you're missing some "WebCore::" on the types. The parameter names
aren't needed here, either.

+++ WebKit/qt/WebCoreSupport/ChromeClientQt.h	(working copy)
@@ -104,7 +104,9 @@ namespace WebCore {
	 virtual void updateBackingStore();
 
	 virtual void repaint(const IntRect&, bool contentChanged, bool
immediate = false);
-
+	 virtual IntPoint screenToWindow(const IntPoint& p) const;
+	 virtual IntRect windowToScreen(const IntRect& r) const;

Parameter names can be omitted.

+++ WebKit/wx/WebKitSupport/ChromeClientWx.h	(working copy)
@@ -99,6 +99,8 @@ public:
     virtual void updateBackingStore();
     
     virtual void repaint(const IntRect&, bool contentChanged, bool immediate =
false);
+    virtual IntPoint screenToWindow(const IntPoint& p) const;
+    virtual IntRect windowToScreen(const IntRect& r) const;

Ditto.

r=me