[webkit-reviews] review granted: [Bug 21278] Rounding behavior of AffineTransform.mapRect should be documented : [Attachment 23982] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 1 12:57:43 PDT 2008

Darin Adler <darin at apple.com> has granted Brett Wilson (Google)
<brettw at chromium.org>'s request for review:
Bug 21278: Rounding behavior of AffineTransform.mapRect should be documented

Attachment 23982: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
Seems fine to add a comment.

But why is it more important to document this for mapRect than for mapPoint,
which is equally ambiguous?

Also, I'm not sure that including the comment without any blank lines is
readable. It might be nicer to have paragraphing that groups the comment with
the mapRect function (either just the IntRect overload, or both of them).

I also think that the wording "The IntRect version" is a little vague; it took
me a while to figure out that you meant the IntRect version of mapRect.

If I was writing the comment I would say something like "this is often helpful
for bounding box computations but may not be what is wanted in contexts".


More information about the webkit-reviews mailing list