[webkit-reviews] review denied: [Bug 21638] WebCore/page/FrameTree.cpp:find() dispatches form submissions to incorrect frame : [Attachment 24681] Revised Fix for FrameTree.cpp for ambiguous frames.

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied John Holdsworth
<webkit at johnholdsworth.com>'s request for review:
Bug 21638: WebCore/page/FrameTree.cpp:find() dispatches form submissions to
incorrect frame
https://bugs.webkit.org/show_bug.cgi?id=21638

Attachment 24681: Revised Fix for FrameTree.cpp for ambiguous frames. 
https://bugs.webkit.org/attachment.cgi?id=24681&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
>+2008-10-26  John Holdsworth  <webkit at johnholdsworth.com>
>+
>+	  Reviewed by NOBODY (OOPS!).
>+
>+	  Frames now searched for by name starting at the innermost frame
>+	  moving up the tree to the outermost containing parent level by level.

>+
>+	  * fast/frames/frameTree-form.html: Added.
>+	  * fast/frames/frameTree-frame.html: Added.
>+	  * fast/frames/frameTree-top.html: Added.

This is a good first step toward a layout test, John!  However, please note
that:

- Layout tests are run in an automated fashion.
- The patch should include the expected results of the tests (see
WebKitTools/Scripts/run-webkit-tests --help).
- Layout tests should not depend on external resources (like www.google.com).

Please see this page for more details:

http://webkit.org/quality/testwriting.html

The easiest thing to do is to look at a similar test when writing your own.

Note that since this is a form submission issue, you may need to write an
"http" test (see LayoutTest/http/tests/) which run under an Apache web server.

r- to fix layout test issues.