[webkit-reviews] review granted: [Bug 22552] Provide some abstraction of JIT code generation, to increase portability. : [Attachment 25593] The patch, having hit 'save' on the Changelog

[bugzilla-daemon at webkit.org]

Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 22552: Provide some abstraction of JIT code generation, to increase
portability.
https://bugs.webkit.org/show_bug.cgi?id=22552

Attachment 25593: The patch, having hit 'save' on the Changelog
https://bugs.webkit.org/attachment.cgi?id=25593&action=review

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
This patch makes the WREC code so much cleaner. It will be a good day when we
can also apply this to the JS JIT.

Most of my comments are about order of declarations. In structs, we generally
put constructors first and members afterwards. In classes, we generally put
public: before private: and do not rely upon the implicit private: of a class
definition.

If you fix up the order of declarations, r=me.