[webkit-reviews] review requested: [Bug 22528] Move currentThreadStackBase() to WTF : [Attachment 25554] Share utility code for GC implementations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 26 23:09:39 PST 2008


Alp Toker <alp at nuanti.com> has asked  for review:
Bug 22528: Move currentThreadStackBase() to WTF
https://bugs.webkit.org/show_bug.cgi?id=22528

Attachment 25554: Share utility code for GC implementations
https://bugs.webkit.org/attachment.cgi?id=25554&action=review

------- Additional Comments from Alp Toker <alp at nuanti.com>
	Split out JSC collector internals to WTF so the code can be shared
	with DOM bindings and WebKit API layer code implementing garbage
	collection.

	This patch splits out what's necessary to support the proposed
	conservative stack-only GC in the GObject C DOM binding.

 JavaScriptCore/AllInOneFile.cpp		     |	  1 
 JavaScriptCore/ChangeLog			     |	 25 ++++
 JavaScriptCore/GNUmakefile.am			     |	  2 
 JavaScriptCore/JavaScriptCore.pri		     |	  1 
 JavaScriptCore/JavaScriptCore.scons		     |	  1 
 JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj |	  8 +
 JavaScriptCore/JavaScriptCoreSources.bkl	     |	  1 
 JavaScriptCore/runtime/Collector.cpp		     |	 73 ------------
 JavaScriptCore/wtf/CollectorUtilities.cpp	     |	117
++++++++++++++++++++
 JavaScriptCore/wtf/CollectorUtilities.h	     |	 35 +++++
 WebCore/ChangeLog				     |	 17 ++
 WebCore/ForwardingHeaders/wtf/CollectorUtilities.h  |	  1 
 WebCore/WebCore.vcproj/WebCore.vcproj		     |	  4 
 13 files changed, 214 insertions(+), 72 deletions(-)

Note that the patch doesn't add the new files to the XCode project files as I
don't have access to the IDE right now. To the reviewer: Please update those
files when landing this, or otherwise update the patch with the necessary
changes so I can get them in. Thanks!


More information about the webkit-reviews mailing list