[webkit-reviews] review denied: [Bug 22374] Need API to access favicons using the favicon URL. : [Attachment 25300] Implementation of the new required API

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Yael <yael.aharon at nokia.com>'s request
for review:
Bug 22374: Need API to access favicons using the favicon URL.
https://bugs.webkit.org/show_bug.cgi?id=22374

Attachment 25300: Implementation of the new required API
https://bugs.webkit.org/attachment.cgi?id=25300&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
If the application needs these icons cached, it seems it should have its own
cache with a lifetime tied to the lifetime of the storage databases.  But maybe
I'm misunderstanding the problem?

Also, you should note that WebCore has no public interfaces.  If you
application directly depends on WebCore it will break in the future.  I'm not
sure if that's the case here or not.  A good example of this is when Qt exposed
the "is this url in your history database" function call from WebCore to Qt
embedders.  This changed when we moved to a better hash-based history lookup,
and broke the Qt build.  Now they have an ugly hack in place to support this
(hopefully soon deprecated Qt API).

Marking as r- to remove it from the review queue pending further comment. 
Certainly please correct me if I've misunderstood.