[webkit-reviews] review requested: [Bug 16814] Give plugin a chance to handle ActiveX objects : [Attachment 25537] patch v7
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 26 14:27:45 PST 2008
Peter Kasting <pkasting at google.com> has asked for review:
Bug 16814: Give plugin a chance to handle ActiveX objects
https://bugs.webkit.org/show_bug.cgi?id=16814
Attachment 25537: patch v7
https://bugs.webkit.org/attachment.cgi?id=25537&action=review
------- Additional Comments from Peter Kasting <pkasting at google.com>
Gah. The plugin interface has changed, which I found out when this got
test-compiled before checkin. Now, at least on Mac, we need to go through
PluginData (which is scoped to a page) instead of the global PluginInfoStore.
The key thing I want to know here is whether, by the time we reach this code,
the Frame's Page or the Page's PluginData can be NULL. If so, I need to check
these instead of blindly dereffing them like this patch does. However I kinda
think they can't be NULL here?
More information about the webkit-reviews
mailing list