[webkit-reviews] review requested: [Bug 21546] [GTK] ATK accessibility enhancements : [Attachment 25534] Create separate objects implemeting separate interfaces

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 21546: [GTK] ATK accessibility enhancements
https://bugs.webkit.org/show_bug.cgi?id=21546

Attachment 25534: Create separate objects implemeting separate interfaces
https://bugs.webkit.org/attachment.cgi?id=25534&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
This is mostly here to start discussing.

The problem:
  - AccessibilityRenderObject::textLength and selection handling is only valid
for Text-Controls. When using a debug build one is running into asserts when
using tools like accerciser.

First approach:
  - Create separate GType's and not everyone is implementing AtkTextInterface
    (and implemented with this patch) to not run into the asserts.

Next steps:
  - Implement AtkTextInterface on a paragraph of text around the ::stringValue
  - Some how dynamically add AtkTextInterface and other implementations of a
GObject* or construct these types dynamically...

I will try to push your other patches forward as well.