[webkit-reviews] review requested: [Bug 18830] Assertion failure (using HashMap empty value) in svg/W3C-SVG-1.1/fonts-glyph-02-t.svg : [Attachment 25524] Fix the calculation for RTL text to stop reading random memory

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 18830: Assertion failure (using HashMap empty value) in
svg/W3C-SVG-1.1/fonts-glyph-02-t.svg
https://bugs.webkit.org/show_bug.cgi?id=18830

Attachment 25524: Fix the calculation for RTL text to stop reading random
memory
https://bugs.webkit.org/attachment.cgi?id=25524&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Same patch, using the svg test again. Regarding correctness: I'm pretty sure
that we stop constructing strings from random parts of memory.
I'm also aware that the SVG text handling needs to be changed to process the
text in logical order to be correct and spec complaint.

So this patch will stop an assert, a real world crash, will fix a test case. On
the other hand it will not be the last thing that is going to happen in regard
to RTL text handling of SVG. So what is our take on real world crashes and
fixes for them?