[webkit-reviews] review denied: [Bug 21953] Small Caps font crashes webkit : [Attachment 25023] Possible patch to issue 21953

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Eric Seidel <eric at webkit.org>'s request for review:
Bug 21953: Small Caps font crashes webkit
https://bugs.webkit.org/show_bug.cgi?id=21953

Attachment 25023: Possible patch to issue 21953
https://bugs.webkit.org/attachment.cgi?id=25023&action=review

------- Additional Comments from mitz at webkit.org
The code change is correct but the analysis in the bug and in the change log is
wrong. The reduction contains only a single code point, U+028C (UTF-8 encoded
as CA 8C). There is a font containing a glyph for this character, so there is
no problem. However, its uppercase counterpart is U+0245, for which there
happens to be no font containing a glyph, leading to characterFontData being 0.
This is handled correctly in the non-small-caps case, but not in the small-caps
case. Please revise the change log.