[webkit-reviews] review denied: [Bug 22070] Add an option to allow scripts to close windows. : [Attachment 25513] Patch to implement this feature

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Zachary Kuznia <zork at chromium.org>'s
request for review:
Bug 22070: Add an option to allow scripts to close windows.
https://bugs.webkit.org/show_bug.cgi?id=22070

Attachment 25513: Patch to implement this feature
https://bugs.webkit.org/attachment.cgi?id=25513&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> +    bool allowScriptsToCloseWindows =
> +	   (settings && settings->allowScriptsToCloseWindows());
No reason to put these on two lines.

> @@ -232,6 +235,7 @@ namespace WebCore {
>	   bool m_zoomsTextOnly : 1;
>	   bool m_enforceCSSMIMETypeInStrictMode : 1;
>	   size_t m_maximumDecodedImageSize;
> +	   bool m_allowScriptsToCloseWindows : 1;
If you move this bool up one place, it will not cause unnessary bloating of the
object.

This patch looks fine, but it is not hooked up to anything.  Usually when we
expose a new setting, we hook it up to the WebPreferences API (or probably SPI
in this case) in WebKit.  r- since this really won't do anything on its own.