[webkit-reviews] review granted: [Bug 20926] Reload of page with an iframe does not refresh iframe content, even if iframe src url changed : [Attachment 24861] proposed fix (sync with related Mac code)

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Michael Moss <mmoss at chromium.org>'s
request for review:
Bug 20926: Reload of page with an iframe does not refresh iframe content, even
if iframe src url changed
https://bugs.webkit.org/show_bug.cgi?id=20926

Attachment 24861: proposed fix (sync with related Mac code)
https://bugs.webkit.org/attachment.cgi?id=24861&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You should consider setting the CHANGE_LOG_NAME environment variable to your
full name.  It seems on google systems the prepare-ChangeLog code is picking up
teh username instead:

my $name = $ENV{CHANGE_LOG_NAME}
  || $ENV{REAL_NAME}
  || gitConfig("user.name")
  || (split /\s*,\s*/, (getpwuid $<)[6])[0]
  || "set REAL_NAME environment variable";

This looks identical to http://trac.webkit.org/changeset/31264 which would
suggest to me it's right.  I'm going to r+ this, but I don't have a working
tree on this box atm, so I can't land it immediately.