[webkit-reviews] review granted: [Bug 22441] Bridge the gap between the generated ElementFactory and HTMLElementFactory : [Attachment 25506] Third part: make some HTML elements take a QualifiedName

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 25 15:53:23 PST 2008


Eric Seidel <eric at webkit.org> has granted Julien Chaffraix
<jchaffraix at pleyo.com>'s request for review:
Bug 22441: Bridge the gap between the generated ElementFactory and
HTMLElementFactory
https://bugs.webkit.org/show_bug.cgi?id=22441

Attachment 25506: Third part: make some HTML elements take a QualifiedName
https://bugs.webkit.org/attachment.cgi?id=25506&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It's possible with this change to actually fix bugs in our XHTML handling, but
you seem to have chosen not to. :)  I think it's find to land as-is, but you
should plan to fix (and test) the real bug with a later change.

The bug:
<foo:html xmlns:foo="http://www.w3c.org/1999/xhtml">

<script>
alert(document.getElementsByTagName("html")[0].prefix)

you get "null", when it should be "foo"

It's probably also possible to repro the bug with:
document.createElementNS("foo:html", "http://www.w3c.org/1999/xhtml")
That would need to be done on an XHTML doc, as I expect that HTML docs ignore
prefixes.

There may already even be a test case testing this.

I look forward to seeing the rest of the patches.


More information about the webkit-reviews mailing list