[webkit-reviews] review requested: [Bug 20534] DumpRenderTree needs a way to override settings on a per-test basis : [Attachment 25496] Improved possible patch for issue 20534

[bugzilla-daemon at webkit.org]

Glenn Wilson <gwilson at google.com> has asked Adam Roben (aroben)
<aroben at apple.com> for review:
Bug 20534: DumpRenderTree needs a way to override settings on a per-test basis
https://bugs.webkit.org/show_bug.cgi?id=20534

Attachment 25496: Improved possible patch for issue 20534
https://bugs.webkit.org/attachment.cgi?id=25496&action=review

------- Additional Comments from Glenn Wilson <gwilson at google.com>
>> Why was this line added? I don't know why I didn't question it before!

Strange.  This line may have been part of the resetWebViewTo... method in the
past, and was removed in a revision since the initial version of the patch. Or
maybe a copy & paste error.  Anyways, it shouldn't be in there, so I removed
it.  Good catch!

Also, rather than just referring to the issue numbers in the ChangeLogs, I
replaced them with links directly to the issues.

Thanks for the review!