[webkit-reviews] review granted: [Bug 22443] XMLHttpRequest's PreflightResultCache should be thread-safe. : [Attachment 25485] Make the PreflightResultCache thread-safe.

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 22443: XMLHttpRequest's PreflightResultCache should be thread-safe.
https://bugs.webkit.org/show_bug.cgi?id=22443

Attachment 25485: Make the PreflightResultCache thread-safe.
https://bugs.webkit.org/attachment.cgi?id=25485&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +2008-11-25  David Levin  <set EMAIL_ADDRESS environment variable>

Please do. Also, please reference this bug in ChangeLog, so that anyone reading
it could easily find the relevant discussions.

> +    bool parse(const ResourceResponse& response);

The argument name should be omitted, because it doesn't add anything that its
type doesn't say (same elsewhere).

> +class PreflightResultCache : public Noncopyable {

We currently use private inheritance for Noncopyable, although it doesn't
really matter.

r=me. I'll address my own comments while landing this patch.