[webkit-reviews] review requested: [Bug 20534] DumpRenderTree needs a way to override settings on a per-test basis : [Attachment 25486] An updated patch for 20534

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 25 10:38:39 PST 2008


Glenn Wilson <gwilson at google.com> has asked Adam Roben (aroben)
<aroben at apple.com> for review:
Bug 20534: DumpRenderTree needs a way to override settings on a per-test basis
https://bugs.webkit.org/show_bug.cgi?id=20534

Attachment 25486: An updated patch for 20534
https://bugs.webkit.org/attachment.cgi?id=25486&action=review

------- Additional Comments from Glenn Wilson <gwilson at google.com>
Here is a revived version of this patch that should apply cleanly.  It looks
like the conflicts came from several new methods were added to
IWebPreferencesPrivate, and the references to WebPreferencesPrivate in
DumpRenderTree having been moved.  

Fortunately, this reduces the number of lines changed by this patch :)


More information about the webkit-reviews mailing list