[webkit-reviews] review granted: [Bug 22473] Unroll the regexp matching loop by 1 : [Attachment 25461] patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted 's request for review:
Bug 22473: Unroll the regexp matching loop by 1
https://bugs.webkit.org/show_bug.cgi?id=22473

Attachment 25461: patch
https://bugs.webkit.org/attachment.cgi?id=25461&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> -void Generator::generateLoopIfNotEndOfInput(JmpDst target)
> +// For the sake of end-of-line assertions, we treat one-past-the-end as if
it
> +// were part of the input string.
> +void Generator::generateJumpIfEndOfInput(JmpSrcVector& failures)
> +{
> +    __ cmpl_rr(Generator::length, Generator::index);
The Generator:: should not be needed here.

r=me