[webkit-reviews] review granted: [Bug 22464] Add a test for a potential crash in same-origin checks : [Attachment 25458] Addressing Darin's and Sam's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 24 17:20:35 PST 2008


Darin Adler <darin at apple.com> has granted Pam Greene <pam at chromium.org>'s
request for review:
Bug 22464: Add a test for a potential crash in same-origin checks
https://bugs.webkit.org/show_bug.cgi?id=22464

Attachment 25458: Addressing Darin's and Sam's comments
https://bugs.webkit.org/attachment.cgi?id=25458&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This looks great. My only concern is that changing the timers to 0-duration
might have made this so it wouldn't crash any more back with the original bug.
It might be more reliable to use an onload handler on the iframe instead.

r=me as is, but this may need to be tested at some point to see if it still
exercises the bug with a 0 timeout.


More information about the webkit-reviews mailing list