[webkit-reviews] review requested: [Bug 22365] Add a test to verify the results of DOM constructors : [Attachment 25457] Shuffled objects and switched to standard JS wrapper

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 24 15:58:01 PST 2008


Pam Greene <pam at chromium.org> has asked  for review:
Bug 22365: Add a test to verify the results of DOM constructors
https://bugs.webkit.org/show_bug.cgi?id=22365

Attachment 25457: Shuffled objects and switched to standard JS wrapper
https://bugs.webkit.org/attachment.cgi?id=25457&action=review

------- Additional Comments from Pam Greene <pam at chromium.org>
(In reply to comment #7)

> Many of the objects tested here are not Nodes, they are just objects exposed
by
> the DOM. 

Renamed the variables for clarity.

Shuffled objects as indicated.

> It would be nice if this test used the shouldBe() style tests.

Done.


More information about the webkit-reviews mailing list