review requested: [Bug 22466] Many resources missing when saving webarchive of webkit.org : [Attachment 25451] Patch v1 (naïve fix)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 24 14:07:37 PST 2008


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 22466: Many resources missing when saving webarchive of webkit.org
https://bugs.webkit.org/show_bug.cgi?id=22466

Attachment 25451: Patch v1 (naïve fix)
https://bugs.webkit.org/attachment.cgi?id=25451&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
This patch fixes the bug, but I don't understand why
DocumentLoader::cachedResource() doesn't have a reference to resources loaded
on the page.  Are we violating a contract, or should we just be checking for
all resources in the WebCore cache instead?


More information about the webkit-reviews mailing list