[webkit-reviews] review granted: [Bug 22295] track which history items are from page load failures : [Attachment 25446] patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 22295: track which history items are from page load failures
https://bugs.webkit.org/show_bug.cgi?id=22295

Attachment 25446: patch
https://bugs.webkit.org/attachment.cgi?id=25446&action=review

------- Additional Comments from mitz at webkit.org
Can you assert that the url parameter to updateGlobalHistory is equal to the
documentLoader's urlForHistory()?

> +    [[WebHistory optionalSharedHistory] _visitedURL:cocoaURL withTitle:title
wasFailure:wasFailure];

I think you can get rid of cocoaURL and pass url directly.

r=me