[webkit-reviews] review granted: [Bug 22464] Add a test for a potential crash in same-origin checks : [Attachment 25442] New test + result

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Pam Greene <pam at chromium.org>'s
request for review:
Bug 22464: Add a test for a potential crash in same-origin checks
https://bugs.webkit.org/show_bug.cgi?id=22464

Attachment 25442: New test + result
https://bugs.webkit.org/attachment.cgi?id=25442&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
The test would be better if it made some visible change to the page inside the
check_blank function just before calling notifyDone. We normally write out
"PASS" in code like that.

That avoids having the test seem to succeed if some bug prevents the code in
the test from running at all.

I'm going to say review+, but the test would be better with that small
refinement.

Also, I'm not sure where the 100ms timeout comes from. Would the test not work
with a 0 timeout?