[webkit-reviews] review requested: [Bug 22432] Add tickmark plumbing support for scrollbars : [Attachment 25409] Second attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 23 21:19:30 PST 2008


Finnur Thorarinsson <finnur.webkit at gmail.com> has asked  for review:
Bug 22432: Add tickmark plumbing support for scrollbars
https://bugs.webkit.org/show_bug.cgi?id=22432

Attachment 25409: Second attempt
https://bugs.webkit.org/attachment.cgi?id=25409&action=review

------- Additional Comments from Finnur Thorarinsson <finnur.webkit at gmail.com>
Darin Adler,

Thank you for taking a stab at this on a weekend day.

You are right, the paintTickmarks call doesn't need to be specific to the
vertical scrollbars. We (Chromium) don't want the tickmarks for horizontal
scrollbars, but that doesn't mean others wont. I have removed that check.

I also removed paintTickmark (singular). I thought it might make sense to
provide guidance for the implementors of the tickmarks (for a given port), but
you are right: we don't need that in the base class.


More information about the webkit-reviews mailing list