[webkit-reviews] review granted: [Bug 22347] Chromium Scons build does not work on Windows : [Attachment 25325] Fix the JSC/Chromium build for Windows

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 22347: Chromium Scons build does not work on Windows
https://bugs.webkit.org/show_bug.cgi?id=22347

Attachment 25325: Fix the JSC/Chromium build for Windows
https://bugs.webkit.org/attachment.cgi?id=25325&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>      ASSERT(m_sourceElements);
> -    functionBodyNode->adoptData(auto_ptr<ScopeNodeData>(new
ScopeNodeData(m_sourceElements.get(),
> +    functionBodyNode->adoptData(std::auto_ptr<ScopeNodeData>(new
ScopeNodeData(m_sourceElements.get(),
>									    
m_varDeclarations ? &m_varDeclarations->data : 0, 
>									    
m_funcDeclarations ? &m_funcDeclarations->data : 0,
>									    
m_numConstants)));

What's this change about? It's not mentioned in the ChangeLog. The right fix
would be to add a "using namespace std" or "using std::auto_ptr" to this source
file, not add an explicit std:: qualification.

rs=me on the scons changes