[webkit-reviews] review granted: [Bug 22371] Add a test for accessing form element items by index : [Attachment 25296] New test + result

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 20 07:44:31 PST 2008


Darin Adler <darin at apple.com> has granted Pam Greene <pam at chromium.org>'s
request for review:
Bug 22371: Add a test for accessing form element items by index
https://bugs.webkit.org/show_bug.cgi?id=22371

Attachment 25296: New test + result
https://bugs.webkit.org/attachment.cgi?id=25296&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Tests like this should be written with the JavaScript test wrapper whenever
possible. Also, it's helpful to test more than just the fact that a value is
not undefined when testing something like this.

For an example, look at something like
fast/dom/HTMLFormElement/elements-not-in-document.html -- tests like that one
are more valuable.

r=me


More information about the webkit-reviews mailing list