[webkit-reviews] review cancelled: [Bug 22328] Worker object should implement WindowTimers interface as per HTML5 spec : [Attachment 25304] Initial Refactoring of code

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has cancelled Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 22328: Worker object should implement WindowTimers interface as per HTML5
spec
https://bugs.webkit.org/show_bug.cgi?id=22328

Attachment 25304: Initial Refactoring of code
https://bugs.webkit.org/attachment.cgi?id=25304&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Aside from code style issues, I have two comments. First, DOMTimer inherits
from TimerBase, which is not thread safe, and doesn't work in non-main threads
anyway (on Mac OS X, it uses CFRunLoopTimerCreate on main run loop). Second,
clearAllTimeouts and related functions need to be modified to take advantage of
DOMTimer being an ActiveDOMObject. Pausing and resuming timers will probably
require support for pausing/resuming active DOM objects, which is needed
anyway.

You may want to discuss this with someone who actually knows how timers used to
work though!