[webkit-reviews] review granted: [Bug 22131] Ports should be able to provide their own visited link hashing and types : [Attachment 25033] Patch for using 64 bits from a separate file

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Brett Wilson (Google)
<brettw at chromium.org>'s request for review:
Bug 22131: Ports should be able to provide their own visited link hashing and
types
https://bugs.webkit.org/show_bug.cgi?id=22131

Attachment 25033: Patch for using 64 bits from a separate file
https://bugs.webkit.org/attachment.cgi?id=25033&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This looks great!

You use "hash" as an overloaded term, we need to qualify it's usage to make
more sense.

 38 // Just use the low 32-bits of the 64-bit hash as the "hash" (which must be
32 bits).

Should be something like:
// Use the low 32 bits of the 64-bit LinkHash as the key for the HashSet


LinkHashHash needs a better name.  yes, I understand that I follows the pattern
of other *Hash structs, but it's confusing. :)	LinkHashHashFunctions would be
better.

Otherwise you're good to go.  I don't need to see this again.  There are
obviously things which could be used to further improve hashing here, but this
is a nice cleanup step at least.