[webkit-reviews] review cancelled: [Bug 16814] Give plugin a chance to handle ActiveX objects : [Attachment 25112] patch v5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 19 17:14:46 PST 2008


Peter Kasting <pkasting at google.com> has cancelled Peter Kasting
<pkasting at google.com>'s request for review:
Bug 16814: Give plugin a chance to handle ActiveX objects
https://bugs.webkit.org/show_bug.cgi?id=16814

Attachment 25112: patch v5
https://bugs.webkit.org/attachment.cgi?id=25112&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Finally had a chance to do some local testing.	Need to add "clsid:" on all the
classids now that we're using string comparison instead of substring search. 
Verified in MSDN and by testing IE that this will work (we won't miss cases
that IE would accept).

Local testing of a variant of this patch in Chromium seems to do what we want
there.


More information about the webkit-reviews mailing list