[webkit-reviews] review granted: [Bug 22358] Add a test for "Copy" after showing a tooltip : [Attachment 25281] New test + result

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 19 11:29:07 PST 2008


Darin Adler <darin at apple.com> has granted Pam Greene <pam at chromium.org>'s
request for review:
Bug 22358: Add a test for "Copy" after showing a tooltip
https://bugs.webkit.org/show_bug.cgi?id=22358

Attachment 25281: New test + result
https://bugs.webkit.org/attachment.cgi?id=25281&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
How long does this test take to run?

A test that intentionally takes multiple seconds to run is not compatible with
the original WebKit regression test philosophy. Anything we can do to avoid
having actual 1-second delays in the test would be worthwhile.

With 8000+ tests we really want them all to run as quickly as possible and
avoid requiring any real time delays. For example, EventSender has a "leap time
forward" feature that we've used in the past to avoid this for some tests.

I'm going to say review+, but I am quite concerned about making our tests take
a long time to run, one test at a time.


More information about the webkit-reviews mailing list