[webkit-reviews] review granted: [Bug 22355] Systematize code for replacing global constructors : [Attachment 25271] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 22355: Systematize code for replacing global constructors
https://bugs.webkit.org/show_bug.cgi?id=22355

Attachment 25271: proposed patch
https://bugs.webkit.org/attachment.cgi?id=25271&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (!static_cast<JSDOMWindowBase*>(thisObject)->allowsAccessFrom(exec))
> +	   return;
> +    // Shadowing a built-in constructor
> +    static_cast<JSDOMWindowBase*>(thisObject)->putDirect(Identifier(exec,
"Event"), value);

How about a helper function for this idiom? I can't think of any good reason to
write this out explicitly 8 times instead of using a function.

r=me