[webkit-reviews] review granted: [Bug 22310] Worker exceptions should be printed to console : [Attachment 25221] updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 19 09:00:10 PST 2008
Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 22310: Worker exceptions should be printed to console
https://bugs.webkit.org/show_bug.cgi?id=22310
Attachment 25221: updated patch
https://bugs.webkit.org/attachment.cgi?id=25221&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> - Document::updateDocumentsRendering();
> + if (scriptExecutionContext->isDocument())
> + Document::updateDocumentsRendering();
Maybe this should be a virtual function on ScriptExecutionContext instead of a
hard-coded rule at the callsite?
> #include "WorkerContext.h"
> +#include "WorkerMessagingProxy.h"
> +#include "WorkerThread.h"
> #include <parser/SourceCode.h>
Why are you adding these includes to WorkerScriptController.cpp?
r=me
More information about the webkit-reviews
mailing list